JonChesterfield added inline comments.
================
Comment at: openmp/libomptarget/src/rtl.cpp:76
+ std::string full_plugin_name;
+ void *handle = dlopen("libomptarget.so", RTLD_NOW);
----------------
JonChesterfield wrote:
> This logic is cut from D73657 without addressing any of the review comments.
> Idea is to look for the offloading plugins next to libomptarget, instead of
> in dlopen's default search path. Will address the previous comments when
> splitting out to a separate patch.
There's a D87413 that I didn't know about before seeing a comment on D73657
just now. That uses RTLD_DI_LINKMAP with dlinfo instead. I'm leaning towards
dladdr because it seems to exist on more platforms but haven't looked into the
options closely yet.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101960/new/
https://reviews.llvm.org/D101960
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
