tlively added inline comments.
================ Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 ---------------- sunfish wrote: > Sorry to throw more paint at the bikeshed here, but as someone who's only > following along at a high-level here, I found it confusing whether this is > talking about the wasm globals themselves, or the objects referred to by > reference values in the wasm globals. I think the feature here is talking > about the wasm globals themselves, but "managed" initially made me think it > might be talking about the objects they reference, which in a browser context > especially are "managed" in every sense of the word. Fair point. What does everyone think about `INDEXED`, because it is used to represent objects given static indexes (in the WebAssembly sense) in the final binary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
