hintonda added inline comments. ================ Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:36 @@ +35,3 @@ + +bool UseNoexceptCheck::helper(const MatchFinder::MatchResult &Result, + const SourceRange &Range, ---------------- alexfh wrote: > The name "helper" doesn't say much. I'm sure we can come up with a much more > useful name. The interface could also be more convenient. It looks like this > function could return a `FixItHint` (which could possibly be `isNull()`, if > no replacement is possible/needed). It could also use an > `Optional<FixItHint>` or some other way to inform the caller that there's no > action required. Happy to rename it, but not sure making it more convenient serves much of a purpose. For this checker, we either find a dynamic exception specification and produce a FixItHint, or we don't.
Did you have some other behavior you wanted me to add? http://reviews.llvm.org/D18575 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
