pxli168 accepted this revision.
pxli168 added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: test/SemaOpenCL/to_addr_builtin.cl:26
@@ +25,3 @@
+#if __OPENCL_C_VERSION__ < CL_VERSION_2_0
+  // expected-error@-2{{'to_global' needs OpenCL version 2.0 or above}}
+#else
----------------
Anastasia wrote:
> @Xiuli, I think Sam is right. Passing constant to generic violates AS 
> conversion rules from s6.5.5. So error would be correct behavior of the 
> compiler.
Yes, I think I just misunderstand some address space problem.


http://reviews.llvm.org/D19932



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to