This revision was automatically updated to reflect the committed changes. Closed by commit rG68a20c7f36d1: [clang] Support -fpic -fno-semantic-interposition for AArch64 (authored by MaskRay).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101873/new/ https://reviews.llvm.org/D101873 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/fsemantic-interposition.c Index: clang/test/Driver/fsemantic-interposition.c =================================================================== --- clang/test/Driver/fsemantic-interposition.c +++ clang/test/Driver/fsemantic-interposition.c @@ -10,6 +10,7 @@ /// If -fno-semantic-interposition is specified and the target supports local /// aliases, neither CC1 option is set. +// RUN: %clang -target aarch64 %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=NO %s // RUN: %clang -target i386 %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=NO %s // RUN: %clang -target x86_64 %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=NO %s // NO-NOT: "-fsemantic-interposition" @@ -20,8 +21,8 @@ /// local aliases, use the traditional half-baked behavor: interprocedural /// optimizations are allowed but local aliases are not used. If references are /// not optimized out, semantic interposition at runtime is possible. -// RUN: %clang -target aarch64 %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=HALF %s // RUN: %clang -target ppc64le %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=HALF %s +// RUN: %clang -target riscv64 %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=HALF %s // RUN: %clang -target x86_64 %s -Werror -fPIC -c -### 2>&1 | FileCheck --check-prefix=HALF %s // Index: clang/lib/Driver/ToolChains/Clang.cpp =================================================================== --- clang/lib/Driver/ToolChains/Clang.cpp +++ clang/lib/Driver/ToolChains/Clang.cpp @@ -4722,7 +4722,7 @@ options::OPT_fno_semantic_interposition); if (RelocationModel != llvm::Reloc::Static && !IsPIE) { // The supported targets need to call AsmPrinter::getSymbolPreferLocal. - bool SupportsLocalAlias = Triple.isX86(); + bool SupportsLocalAlias = Triple.isAArch64() || Triple.isX86(); if (!A) CmdArgs.push_back("-fhalf-no-semantic-interposition"); else if (A->getOption().matches(options::OPT_fsemantic_interposition))
Index: clang/test/Driver/fsemantic-interposition.c =================================================================== --- clang/test/Driver/fsemantic-interposition.c +++ clang/test/Driver/fsemantic-interposition.c @@ -10,6 +10,7 @@ /// If -fno-semantic-interposition is specified and the target supports local /// aliases, neither CC1 option is set. +// RUN: %clang -target aarch64 %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=NO %s // RUN: %clang -target i386 %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=NO %s // RUN: %clang -target x86_64 %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=NO %s // NO-NOT: "-fsemantic-interposition" @@ -20,8 +21,8 @@ /// local aliases, use the traditional half-baked behavor: interprocedural /// optimizations are allowed but local aliases are not used. If references are /// not optimized out, semantic interposition at runtime is possible. -// RUN: %clang -target aarch64 %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=HALF %s // RUN: %clang -target ppc64le %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=HALF %s +// RUN: %clang -target riscv64 %s -Werror -fPIC -fno-semantic-interposition -c -### 2>&1 | FileCheck --check-prefix=HALF %s // RUN: %clang -target x86_64 %s -Werror -fPIC -c -### 2>&1 | FileCheck --check-prefix=HALF %s // Index: clang/lib/Driver/ToolChains/Clang.cpp =================================================================== --- clang/lib/Driver/ToolChains/Clang.cpp +++ clang/lib/Driver/ToolChains/Clang.cpp @@ -4722,7 +4722,7 @@ options::OPT_fno_semantic_interposition); if (RelocationModel != llvm::Reloc::Static && !IsPIE) { // The supported targets need to call AsmPrinter::getSymbolPreferLocal. - bool SupportsLocalAlias = Triple.isX86(); + bool SupportsLocalAlias = Triple.isAArch64() || Triple.isX86(); if (!A) CmdArgs.push_back("-fhalf-no-semantic-interposition"); else if (A->getOption().matches(options::OPT_fsemantic_interposition))
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits