DavidSpickett added a reviewer: ychen.
DavidSpickett added a comment.

This works as expected, let me know if this is the intended use relative to the 
changes you made.

The existing test in llvm `llvm/test/CodeGen/AArch64/inline-asm-clobber.ll` 
never reported the location in the .ll file so I can't test it there. (which 
might be its own issue) I looked for any similar tests but didn't find 
anything, testing from clang with a C file seems like the only way.



================
Comment at: clang/test/Misc/inline-asm-clobber-warning.c:26
+// CHECK-NEXT:         nop
+// CHECK-NEXT: ^
----------------
I think this `^` is wrong because we don't/can't account for the asm printer 
tabbing in the instruction.

I still wanted to check that there are `^` just because it's one aspect of the 
location information.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102244/new/

https://reviews.llvm.org/D102244

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to