njames93 added a comment. I think the best method is to
In D86671#2750957 <https://reviews.llvm.org/D86671#2750957>, @dougpuob wrote: > Hi @njames93: > Could you do me a favor? Because it is my first patch, something I'm not > sure. I'm confused about can I land this patch now? I read the "LLVM > Code-Review Policy and Practices" document, it said patches can be landed if > received a LGTM, but seems you are still reviewing. If you have made significant changes (excluding what a reviewer asks when giving an LGTM) Its best to get those further changes also reviewed. ================ Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:348 +getFileStyleFromOptions(const ClangTidyCheck::OptionsView &Options, + ClangTidyContext &Context) { + IdentifierNamingCheck::HungarianNotationOption HNOption; ---------------- Rather than passing the ClangTidyContext, Make this function a method of IdentifierNamingCheck. Then you call create the Diag without worrying about the Context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
