nickdesaulniers added inline comments.
================ Comment at: llvm/test/LTO/AArch64/stack-protector-guard-module-attrs.ll:2-5 +; RUN: not llvm-link %t/a.ll %t/b.ll 2>&1 | FileCheck --check-prefix=CHECK-KIND %s +; RUN: not llvm-link %t/c.ll %t/d.ll 2>&1 | FileCheck --check-prefix=CHECK-REG %s +; RUN: not llvm-link %t/e.ll %t/f.ll 2>&1 | FileCheck --check-prefix=CHECK-OFFSET %s +; RUN: llvm-link %t/g.ll %t/h.ll ---------------- nickdesaulniers wrote: > I used `llvm-link` here, but please let me know if it would be preferable to > convert these to use `llvm-lto2` instead? > > Also, is there any issue with this new dir, `llvm/test/LTO/AArch64/`? Do I > need to modify any lit cfg files so that the tests don't run for non-aarch64? > > Also, I guess this test isn't really specific to aarch64; I don't do any > codegen and don't specify the target triple (though, these module attributes > only will be emitted from the front end for x86 and aarch64 at the moment; > perhaps riscv and ppc64le in the future). Perhaps I should move this test under llvm/test/tools/llvm-link/ or llvm/test/Linker/ ? llvm/test/Linker/ has lots of tests that invoke `llvm-link`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
