jwtowner added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/ForwardingReferenceOverloadCheck.cpp:83 + hasType(isEnableIf()), + anyOf(hasDescendant(cxxBoolLiteral()), + hasDescendant(cxxNullPtrLiteralExpr()), ---------------- Note that I'm using `hasDescendant` here, because sometimes the literal ends up inside of an `ImplicitCastExpr` node and sometimes its a direct child of the `NonTypeTemplateParmDecl` node. I'm not sure exactly what causes the difference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103385/new/ https://reviews.llvm.org/D103385 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
