probinson added a comment. In D103131#2789493 <https://reviews.llvm.org/D103131#2789493>, @probinson wrote:
>> Mixed feelings - somewhat in favor of "do the thing that's probably already >> fairly tested/known to work" (GCC's thing). But open to the idea that that >> approach has problems, for sure. > > "Known to work" for whom? gdb, sure, because gcc/gdb cooperate on many > things. I'll have to check with my debugger guys whether this would work for > us; and I'll just reiterate that it's certainly not what the DWARF spec > suggests should be done. The Sony debugger will not be able to figure out the address of "newname" given the DWARF as emitted by gcc (because it looks like an external declaration with no address). We'd much rather have the DW_TAG_imported_declaration that the original patch had. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103131/new/ https://reviews.llvm.org/D103131 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
