nickdesaulniers added inline comments.

================
Comment at: clang/test/Driver/aarch64-target-as-march.s:4
+
+/// The last -march wins, and is handled before -Wa,march. All the values of 
-Wa,march options are added.
+// RUN: %clang --target=aarch64-linux-gnueabi -### -c -Wa,-march=armv8.1-a 
-march=armv8.2-a -Wa,-march=armv8.3-a -Wa,-march=armv8.4-a %s 2>&1 | \
----------------
https://reviews.llvm.org/D95872 tests were pretty extensive.  We don't need 
`-mcpu` tests like https://reviews.llvm.org/D95872 had, but I think it might be 
interesting to add more tests, particularly one that verifies `-Wa,-march` is 
overriding `-march`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103184/new/

https://reviews.llvm.org/D103184

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to