tejohnson added inline comments.
================
Comment at: clang/test/Driver/hip-options.hip:72
+// HIPTHINLTO-NOT: error: invalid argument '-fwhole-program-vtables' only
allowed with '-flto'
+// HIPTHINLTO-NOT: clang{{.*}} "-triple" "x86_64-unknown-linux-gnu" {{.*}}
"-flto-unit"
+// HIPTHINLTO: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-flto=thin"
"-flto-unit" {{.*}} "-fwhole-program-vtables"
----------------
These are essentially the same checks as before, but I renamed this tag to
HIPTHINLTO, added a check to ensure we don't get the error with
-fwhole-program-vtables, ensure -fwhole-program-vtables passed through for the
offload cc1 command, and added a duplicate of the HIPTHINLTO-NOT check (since
in my local build the non-offload cc1 is emitted after the offload cc1, not
sure if there is some variation).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103579/new/
https://reviews.llvm.org/D103579
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
