cameron314 added inline comments.
================
Comment at: lib/Frontend/ASTUnit.cpp:1402-1406
@@ +1401,7 @@
+
+ vfs::Status Status;
+ if (FileMgr->getNoncachedStatValue(RB.first, Status)) {
+ AnyFileChanged = true;
+ break;
+ }
+
----------------
rsmith wrote:
> Suppose file names A and B refer to file (inode) X, and the map contains X ->
> (A, hash). If B is deleted (and maybe recreated pointing at a new inode),
> this approach won't detect that anything has changed.
Ah, I understand. The problem isn't really with the overridden file map, which
still has to be by inode in order for lookups to find the right file regardless
of name, but with the FilesInPreamble map, which needs to stay as a list of
independent filenames in case the inodes associated to those filenames changes
in between parses.
I'll make the change, thanks!
http://reviews.llvm.org/D20137
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
