nickdesaulniers added a comment. In D103184#2813748 <https://reviews.llvm.org/D103184#2813748>, @thakis wrote:
> In D103184#2804241 <https://reviews.llvm.org/D103184#2804241>, @jcai19 wrote: > >> In D103184#2803768 <https://reviews.llvm.org/D103184#2803768>, @thakis wrote: >> >>> FWIW the failure goes away locally if I revert this change here, so it's >>> definitely due to this change here. >>> >>> Things have been red for a while, probably good to revert while you >>> investigate by this point. >> >> Sorry for the delay but my macbook had some issues so I just finished >> building LLVM, but I can't seem to reproduce the test failure locally >> (neither by running the test directly with llvm-lit nor with `ninja >> check-clang`). In fact I don't quite understand why this test failed. Like >> @nickdesaulniers mentioned the build failure should have been fixed in >> https://reviews.llvm.org/rG76d9bc72784d88f4dd57b9939e52c73739438af5 for a >> different patch. Do you mind sharing the instructions you used to reproduce >> the test failure? Thanks. > > Did you try on a mac with a m1 processor? This suggestion doesn't make sense to me. The order of events: 1. https://reviews.llvm.org/rG3cc3c0f8352ec33ca2f2636f94cb1d85fc57ac16 landed, broke the build 2. 1 was reverted in https://reviews.llvm.org/rGbf2479c347c8ca88fefdb144d8bae0a7a4231e2a 3. 1 was relanded in https://reviews.llvm.org/rG76d9bc72784d88f4dd57b9939e52c73739438af5 4. different patch was landed https://reviews.llvm.org/rGfd11a26d368c5a909fb88548fef2cee7a6c2c931 5. @thakis reports patch from 4 causes a test failure, but the test failure looks like the test failure from 1, not 4. 6. 4 is reverted in https://reviews.llvm.org/rG9145a3d4ab7eb05d9fb113b5392e8961df629b88 #5 doesn't make sense to me, and I don't see how the test would turn out differently on an m1 mac vs x86 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
