shchenz added a comment. Thanks for review @stuart
In D104291#2819398 <https://reviews.llvm.org/D104291#2819398>, @stuart wrote: > This looks good to me. > > @jzzheng22 informs me there was a comment in D99250 > <https://reviews.llvm.org/D99250> to the effect that DW_LANG_C_plus_plus_03 > is not emitted, at all - it too was introduced in DWARF 5. I wonder if this > should be addressed in a separate commit? Yes, this was noticed when D99250 <https://reviews.llvm.org/D99250> was posted. There is no `CPlusPlus03` in `LangOptions`, so it is better not to merge `DW_LANG_C_plus_plus_03` support with D99250 <https://reviews.llvm.org/D99250>. > As mentioned in D104118 <https://reviews.llvm.org/D104118>, there are > language codes of DW_LANG_C_plus_plus_17 and DW_LANG_C_plus_plus_20 that will > be introduced in DWARF 6, which it would be good to use in non-strict mode. > This would allow us to emit the more proper code of DW_LANG_C_plus_plus_17 > (instead of DW_LANG_C_plus_plus_14) for //C++ for OpenCL//, while we wait for > DW_LANG_CPP_for_OpenCL to get added, as requested at > http://dwarfstd.org/ShowIssue.php?issue=210514.1. Should this be addressed > in a third commit? Yes, we don't have `DW_LANG_C_plus_plus_17` and `DW_LANG_C_plus_plus_20` in clang for now. I guess this is because clang does not support DWRAF 6. DWARF 6 is not officially released? Once DWARF 6 is released and clang starts to support DWARF 6, I think we should add the support for `DW_LANG_C_plus_plus_17` and `DW_LANG_C_plus_plus_20` in the place that this patch changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104291/new/ https://reviews.llvm.org/D104291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
