erichkeane added a comment.
This seems to do a lot of work that I think already exists, I believe I've seen
that SPIRV targets already prohibit long-double, so doing another
implementation specifically for x86 seems like the wrong approach. I'd suggest
seeing if the SPIRV version works for these. If it doesn't, I'd prefer you
generalize that implementation.
================
Comment at: clang/include/clang/Basic/TargetInfo.h:599
+ /// Determine whether the long double type is supported on this target.
+ virtual bool hasLongDoubleType() const { return HasLongDouble; }
+
----------------
I think SPIR targets already do something like this, can you check and see how
they do it instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98895/new/
https://reviews.llvm.org/D98895
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
