ASDenysPetrov added a comment.

In D103096#2821750 <https://reviews.llvm.org/D103096#2821750>, @vsavchenko 
wrote:

> Hey, great work!  I think that casts are extremely important, but it looks 
> like you mixed so many things into this patch.  Let's make one step at a time 
> a split it into (at least) a couple of patches.

Thanks for the tips. I'll adress them in the next update. Actually, I thought 
about splitting before the first upload and splitted it into D103094 
<https://reviews.llvm.org/D103094> and the current one. This particular patch 
provides full mechanism implementing feasibility of the test cases. Honestly, I 
don't know what part could be cut to keep this mechanism holistic and 
self-sufficient. But I'll see what i can do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103096/new/

https://reviews.llvm.org/D103096

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to