MyDeveloperDay added a comment.

This patch needs rebasing, please also make comments as "Done" once you have 
addressed them.



================
Comment at: clang/lib/Format/TokenAnnotator.cpp:4162
+    return FormatStyle::PAS_Middle;
+  }
+}
----------------
you are missing a return value here

```
C:\cygwin64\buildareas\clang\llvm-project\clang\lib\Format\TokenAnnotator.cpp(4264)
 : warning C4715: 'clang::format::TokenAnnotator::getTokenReferenceAlignment': 
not all control paths return a value
```




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104096/new/

https://reviews.llvm.org/D104096

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D1040... Seraphime Kirkovski (VMware) via Phabricator via cfe-commits
    • [PATCH] ... MyDeveloperDay via Phabricator via cfe-commits
    • [PATCH] ... Björn Schäpers via Phabricator via cfe-commits
    • [PATCH] ... Seraphime Kirkovski (VMware) via Phabricator via cfe-commits
    • [PATCH] ... MyDeveloperDay via Phabricator via cfe-commits
    • [PATCH] ... Seraphime Kirkovski (VMware) via Phabricator via cfe-commits
    • [PATCH] ... Seraphime Kirkovski (VMware) via Phabricator via cfe-commits
    • [PATCH] ... Björn Schäpers via Phabricator via cfe-commits
    • [PATCH] ... Seraphime Kirkovski (VMware) via Phabricator via cfe-commits
    • [PATCH] ... Björn Schäpers via Phabricator via cfe-commits
    • [PATCH] ... MyDeveloperDay via Phabricator via cfe-commits
    • [PATCH] ... Seraphime Kirkovski (VMware) via Phabricator via cfe-commits
    • [PATCH] ... Seraphime Kirkovski (VMware) via Phabricator via cfe-commits
    • [PATCH] ... Seraphime Kirkovski (VMware) via Phabricator via cfe-commits
    • [PATCH] ... Björn Schäpers via Phabricator via cfe-commits

Reply via email to