This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6765b9c3f119: [clangd] Explicitly fail if the file passed to
--check is not valid. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104455/new/
https://reviews.llvm.org/D104455
Files:
clang-tools-extra/clangd/tool/ClangdMain.cpp
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
===================================================================
--- clang-tools-extra/clangd/tool/ClangdMain.cpp
+++ clang-tools-extra/clangd/tool/ClangdMain.cpp
@@ -909,7 +909,11 @@
if (CheckFile.getNumOccurrences()) {
llvm::SmallString<256> Path;
- llvm::sys::fs::real_path(CheckFile, Path, /*expand_tilde=*/true);
+ if (auto Error =
+ llvm::sys::fs::real_path(CheckFile, Path, /*expand_tilde=*/true)) {
+ elog("Failed to resolve path {0}: {1}", CheckFile, Error.message());
+ return 1;
+ }
log("Entering check mode (no LSP server)");
uint32_t Begin = 0, End = std::numeric_limits<uint32_t>::max();
if (!CheckFileLines.empty()) {
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
===================================================================
--- clang-tools-extra/clangd/tool/ClangdMain.cpp
+++ clang-tools-extra/clangd/tool/ClangdMain.cpp
@@ -909,7 +909,11 @@
if (CheckFile.getNumOccurrences()) {
llvm::SmallString<256> Path;
- llvm::sys::fs::real_path(CheckFile, Path, /*expand_tilde=*/true);
+ if (auto Error =
+ llvm::sys::fs::real_path(CheckFile, Path, /*expand_tilde=*/true)) {
+ elog("Failed to resolve path {0}: {1}", CheckFile, Error.message());
+ return 1;
+ }
log("Entering check mode (no LSP server)");
uint32_t Begin = 0, End = std::numeric_limits<uint32_t>::max();
if (!CheckFileLines.empty()) {
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
