xazax.hun added a comment.
I believe there are a couple of comments that are done but not marked
accordingly.
I agree with Artem, if we could craft code that fails due to not calling ctors,
we should probably include them in the tests, even if they don't reflect the
desired behavior they are a great source of documentation what is missing.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:151
+ const auto &TemplateArgs = FD->getTemplateSpecializationArgs()->asArray();
+ if (TemplateArgs.size() == 0)
+ return {};
----------------
Nit: consider `TemplateArgs.empty()`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103750/new/
https://reviews.llvm.org/D103750
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
