Anastasia added a comment.

Looking good already! I just have one general concern about committing 16K 
lines of code with no tests. But perhaps testing all the declarations isn't an 
option actually.

Could we at least have a test that includes the header and makes sure it's 
compiled successfully. Any thought's on this?

Also I can see that other headers are added to lib/Headers/CMakeLists.txt.


http://reviews.llvm.org/D18369



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to