JonChesterfield added a reviewer: ronlieb.
JonChesterfield added a comment.

this unblocks the hazard I am concerned about for D104904 
<https://reviews.llvm.org/D104904>, namely it stops us defining `__CUDA__` when 
compiling amdgcn code that includes complex.h



================
Comment at: clang/lib/Headers/__clang_cuda_complex_builtins.h:21
 #pragma omp declare target
 #define __DEVICE__ __attribute__((noinline, nothrow, cold, weak))
 #else
----------------
bit weird that these are weak, but not changing that here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105221/new/

https://reviews.llvm.org/D105221

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to