chh added a comment. Sam, the revision summary is updated. Could you review it again?
The new summary would clarify a few points: - This --skip-headers is a new feature, not just a transparent run-time saving. It should be used carefully with header-filter and system-headers, and similarly handled in IO.mapOptional. - It's not PCH. - It uses set/getTraversalScope as an implementation method, but the goal of skip-headers is not to limit clang-tidy to see only non-header Decls. - Improvements on PPCallback-based and static analyzer checks could be in follow up changes. The gain might not be as large as the MatchFinder-based checks and the implementation could be more complicated than using set/getTraversalScope. I am glad that with your help on set/getTraversalScope, many part of this revision has become much simpler. I am looking forward to applying this new feature, even with only part 1, to save very significant Android build time, but I am also extremely cautious not to combine many risky changes into one big revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
