ASDenysPetrov added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1203 + if (!Opts.ShouldSupportSymbolicIntegerCasts) + return VisitSymExpr(Sym); + ---------------- vsavchenko wrote: > Why do you use `VisitSymExpr` here? You want to interrupt all `Visits or... > I'm not sure I fully understand. Here we want to delegate the reasoning to another handler as we don't support non-integral cast yet. ================ Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1215 + QualType T = RootSym->getType(); + if (!T->isIntegralOrEnumerationType()) + return VisitSymExpr(Sym); ---------------- vsavchenko wrote: > Can we get a test for that? I'll add some. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
