Anastasia added a comment. This seems reasonable.
================ Comment at: clang/test/SemaOpenCL/null_literal.cl:7 #define NULL ((void*)0) ---------------- I think we should remove this `NULL` definition but instead add `-finclude-default-header -fdeclare-opencl-builtins` to test the definition you are adding in the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105988/new/ https://reviews.llvm.org/D105988 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
