jamieschmeiser added inline comments.
================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2971
+ isEmittedWithConstantInitializer(VD, true) &&
+ !VD->needsDestruction(getContext())) {
+ // Emit a weak global function referring to the initialization function.
----------------
hubert.reinterpretcast wrote:
> Unfortunately `needsDestruction` cannot be counted on at this time for some
> incomplete types, see https://llvm.org/pr51079.
I think it is okay to leave the code as-is as it will then be fixed when that
problem is fixed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104420/new/
https://reviews.llvm.org/D104420
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
