nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land.
LGTM other than the comment that wasn't addressed (which I assume will be addressed in a subsequent patch). ================ Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3087 // RM should be set. +let hasSideEffects = 1 in { def MTFSB0 : XForm_43<63, 70, (outs), (ins u5imm:$FM), ---------------- nemanjai wrote: > I think we should conservatively set RM as an implicit def here. @ZhangKang > you modified this code most recently, please provide your opinion here. This was not addressed. Will this be added in a follow-up patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105930/new/ https://reviews.llvm.org/D105930 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits