vitalybuka added inline comments.

================
Comment at: llvm/test/CodeGen/hwasan-stack-safety-analysis-asm.c:8
+
+int main(int argc, char **argv) {
+  char buf[10];
----------------
these tests do not work because %clang is not defined here, in LLVM
you can keep them but they need to stay in clang/

my request was to add new tests in 
llvm-project/llvm/test/Instrumentation/HWAddressSanitizer/
and they need to be *.ll tests
you probably can generate them from C and cleanup manually
or close existing *.ll tests and CHECK for expected difference if analysis is 
enabled

Also try to generated CHECK statements with llvm/utils/update_test_checks.py, 
often result is quite useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105703/new/

https://reviews.llvm.org/D105703

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to