eugenis added a comment. In D105703#2884056 <https://reviews.llvm.org/D105703#2884056>, @vitalybuka wrote:
> In D105703#2883666 <https://reviews.llvm.org/D105703#2883666>, @eugenis wrote: > >> Btw Vitaly, will this work with LTO out of the box? I think we used to add >> pre-LTO StackSafety pass explicitly for memtag only, but it looks like that >> code is gone. > > What do you mean gone? Can you show me the patch? > > We probably needs something to add analysis for HWASAN as well. https://reviews.llvm.org/D80771 ================ Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:427 + bool DisableOptimization) { assert(!CompileKernel || Recover); + return new HWAddressSanitizerLegacyPass(CompileKernel, Recover, ---------------- vitalybuka wrote: > @eugenis unrelated to the patch, but why do we this args if then we > assert(!CompileKernel || Recover); why not? This forbids CompileKernel && !Recover, how else would you represent the 3 remaining combinations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
