I don't think we even need a helper. Clang::ConstructJob takes a `Compilation`, which has a `Driver`, which has a `DiagnosticsEngine`, which has a `DiagnosticsOptions`.
In other words, I think you can delete the code in Clang::ConstructJob (change it to a lookup) now that you've changed clang::ParseDiagnosticArgs to update `DiagnosticsOptions`. > On 2016-May-18, at 18:54, Sean Silva <chisophu...@gmail.com> wrote: > > silvas added a subscriber: silvas. > silvas added a comment. > > I don't see an issue with putthing this as a helper in libBasic. We may need > to add a libOption dependency to it but that sounds fine. > > > http://reviews.llvm.org/D20404 > > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
