kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks! ================ Comment at: clang-tools-extra/clangd/Preamble.cpp:87 + + const SourceManager &SM = CI.getSourceManager(); + const FileEntry *MainFE = SM.getFileEntryForID(SM.getMainFileID()); ---------------- nit: maybe do this at the top and keep the early exit? ================ Comment at: clang-tools-extra/clangd/Preamble.cpp:400 + std::move(StatCache), CapturedInfo.takeCanonicalIncludes()); + Result->MainIsIncludeGuarded = CapturedInfo.isMainFileIncludeGuarded(); + return Result; ---------------- any reason for not making this part of the constructor ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106203/new/ https://reviews.llvm.org/D106203 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
