josemonsalve2 marked 2 inline comments as done.
josemonsalve2 added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6659
     }
     return nullptr;
   }
----------------
Should I default here to 1? Since this is an `omp target` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106298/new/

https://reviews.llvm.org/D106298

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D106298:... Jose Manuel Monsalve Diaz via Phabricator via cfe-commits
    • [PATCH] D10... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D10... Jose Manuel Monsalve Diaz via Phabricator via cfe-commits
    • [PATCH] D10... Jose Manuel Monsalve Diaz via Phabricator via cfe-commits
    • [PATCH] D10... Jose Manuel Monsalve Diaz via Phabricator via cfe-commits
    • [PATCH] D10... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D10... Jose Manuel Monsalve Diaz via Phabricator via cfe-commits
    • [PATCH] D10... Jose Manuel Monsalve Diaz via Phabricator via cfe-commits
    • [PATCH] D10... Jose Manuel Monsalve Diaz via Phabricator via cfe-commits

Reply via email to