MaskRay added inline comments.
================ Comment at: clang/tools/libclang/CMakeLists.txt:82 + +if (LLVM_EXPORTED_SYMBOL_FILE) + add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} ---------------- tstellar wrote: > MaskRay wrote: > > What does this do? > > > > A hard-coded list cannot catch up with the real dynamic symbol list. We'll > > have to parse llvm-readelf --dyn-syms output... > Are you saying we should generate the version script using llvm-readelf? We may need a test checking that if --version-script is used, there is no `clang_*` symbol which isn't versioned. This can be checked by running `llvm-nm -Dj --defined-only` on libclang.so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits