dexonsmith added a comment. In D105491#2893632 <https://reviews.llvm.org/D105491#2893632>, @simon_tatham wrote:
> In D105491#2891860 <https://reviews.llvm.org/D105491#2891860>, @dexonsmith > wrote: > >> although it'd be good to get someone more involved in lib/CodeGen to take a >> quick look / sign off (ideally someone that knows the use case for >> `!srcloc`...). > > Any idea who that might be? Looking through the logs, @lattner seems to have > made all the commits that set up `!srcloc` in the first place, and nobody > seems to have modified the mechanism much since then. I wonder if this is even reachable anymore, given that the one testcase is inline asm (I believe the frontend catches inline asm errors now) -- I mean, CGStmt still attaches these, but maybe the backend never fires a diagnostic in practice because the frontend error checking is good enough to avoid emitting IR that's broken. (Could be useful for other frontends, maybe, though...) Anyway, I'm comfortable signing off; feel free to commit without finding someone else (remember to add a comment to the testcase). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105491/new/ https://reviews.llvm.org/D105491 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
