aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D104601#2895941 <https://reviews.llvm.org/D104601#2895941>, @Meinersbur wrote: > I compiled the Linux kernel (default config, excludes most drivers. Takes > ~18mins to compile) and indeed found two problems: Thank you, that's super helpful validation! > The clang-13 release branch will be created on July 27. Is there any hope to > get this merged by then? I think there is, but I'm an eternal optimist. :-) This LGTM, but you should wait a day or two before landing it in case @dblaikie or @rsmith have concerns. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6059-6062 + if (!types::isCXX(InputType) && !types::isOpenCL(InputType) && + !types::isObjC(InputType) && !types::isCuda(InputType) && + !types::isHIP(InputType) && InputType != types::TY_PP_C && + InputType != types::TY_C) ---------------- One downside to this approach as opposed to using a `switch` is that it'll be easy to add new languages and forget to update this. However, we don't do that particularly often and this will loudly tell users about the lack of support, so I think it's fine as-is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
