lei added inline comments.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15133 + bool IsLE = getTarget().isLittleEndian(); + auto StoreSubVec = [&](unsigned Width, unsigned Offset, unsigned EltNo) { + switch (Width) { ---------------- I find the nested switch to be a bit confusing at first. Maybe it can be done a bit diff? ``` auto StoreSubVec ... if (Width==16) { } switch (Width) { default: ... case : //set the ConvTy, NumElts for non-16byte widths } // code to handle non-16 byte stores } ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106757/new/ https://reviews.llvm.org/D106757 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits