gAlfonso-bit added a comment. In D106899#2910655 <https://reviews.llvm.org/D106899#2910655>, @MaskRay wrote:
> I migrated all llvm/ files. You need to remove them from the patch. > > It is a good idea to drop the macro definition in > `llvm/include/llvm/Support/Compiler.h` separately. > > It makes it easy to bring back the definition if some important downstream > users want extended time for migration. > (Note: the policy is that downstream is on their own. Our thinking of this is > kindness, not an obligation of llvm-project.) > For example, swift is using `LLVM_ATTRIBUTE_NORETURN`. > (I researched a bit: `LLVM_ATTRIBUTE_NORETURN` is not common in downstream > projects.) Alright, but can we cherry pick this to release when this is all said and done? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
