craig.topper added inline comments.
================ Comment at: clang/lib/Basic/Targets/RISCV.cpp:108 case 'v': - R = std::string("v"); + R = std::string("@2") + std::string(Constraint, 2); Constraint += 1; ---------------- I believe most targets use `std::string("^") + std::string(Constraint, 2)` for 2 letter constraints AArch64 added the @ format and uses @3 for a 3 letter constraint. But it didn't get documented in the LangRef. Can we use the ^ here which is documented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107139/new/ https://reviews.llvm.org/D107139 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits