alexfh added a comment.

In D104601#2916973 <https://reviews.llvm.org/D104601#2916973>, @Meinersbur 
wrote:

> @romanovvlad This is due to -fms-extensions. It Expands `__Pragma` to 
> `#pragma` instead of keeping it a `__Pragma`. This is a one-line fix.
>
> @alexfh This was fixed by D106924 <https://reviews.llvm.org/D106924>

You're right. It turns out that my comment 
https://reviews.llvm.org/D104601#2915122 was a mistake and 
c6b0b16c0f55c34f4eaa05184815bbbe97f4b750 
<https://reviews.llvm.org/rGc6b0b16c0f55c34f4eaa05184815bbbe97f4b750> actually 
fixes this particular issue.

> I would suggest to not revert. Will upload a patch for `-fms-extensions` 
> after some cleanup.

I'm running more thorough testing of clang with the 
c6b0b16c0f55c34f4eaa05184815bbbe97f4b750 
<https://reviews.llvm.org/rGc6b0b16c0f55c34f4eaa05184815bbbe97f4b750> commit to 
ensure we're not missing anything else here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104601/new/

https://reviews.llvm.org/D104601

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to