Ericson2314 marked 2 inline comments as done. Ericson2314 added inline comments.
================ Comment at: llvm/CMakeLists.txt:589 CACHE STRING "Doxygen-generated HTML documentation install directory") -set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html" +set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/${project}/ocaml-html" CACHE STRING "OCamldoc-generated HTML documentation install directory") ---------------- compnerd wrote: > Why the change from `llvm` -> `${project}`? (not that it really makes a > difference) To be honest, I forgot. I might have just been OCD deduping on the fly. Happy to change back, ================ Comment at: llvm/cmake/modules/CMakeLists.txt:3 -set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm) +set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm CACHE STRING "Path for CMake subdirectory (defaults to 'cmake/llvm')") set(llvm_cmake_builddir "${LLVM_BINARY_DIR}/${LLVM_INSTALL_PACKAGE_DIR}") ---------------- compnerd wrote: > Why is this variable being put into the cache now? I wanted all the installation dirs to be in there for consistency (c.f. Did the same for compiler-rt in D105765). FWIW I have a yet-unposted commit I want to improve a bit to make it more genuinely user-configurable too (we want the CMake with the headers so it need not be installed runtime) ================ Comment at: llvm/tools/llvm-config/llvm-config.cpp:361 + { + SmallString<256> Path(StringRef(LLVM_INSTALL_INCLUDEDIR)); + sys::fs::make_absolute(ActivePrefix, Path); ---------------- compnerd wrote: > Why the temporary `StringRef`? Can you not just initialize `Path` with the > literal? I'm not sure. I would think so too, but the old code was also using `StringRef` so I just followed cargo culted and went with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits