aaron.ballman added a comment. In D107402#2925402 <https://reviews.llvm.org/D107402#2925402>, @erichkeane wrote:
> The changes in this patch are all fine to me! I'm a little disturbed that it > only broke 1 test though... Thanks for the review! The test coverage for driver diagnostics definitely appears to be lacking. I don't intend to add the missing test coverage myself as part of this cleanup, but when we review driver changes, we should be more insistent at requiring tests to exercise the diagnostics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://reviews.llvm.org/D107402 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
