sfertile marked 2 inline comments as done.
sfertile added inline comments.
================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1783
+ if (FieldPacked) {
+ FieldAlign = UnpackedFieldAlign = 1;
+ } else if (!MaxFieldAlignment.isZero()) {
----------------
stevewan wrote:
> `UnpackedFieldAlign` is used to check if the packed attribute is unnecessary
> (-Wpacked). here the attribute is making a difference, we probably shouldn't
> set `FieldAlign = UnpackedFieldAlign`?
Good catch, updated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106900/new/
https://reviews.llvm.org/D106900
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
