Jake-Egan updated this revision to Diff 364330. Jake-Egan added a comment. Add comment. clang-format suggests a second indent, but I think this is correct because the comment is addressing the else clause.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107244/new/ https://reviews.llvm.org/D107244 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Preprocessor/init-ppc.c Index: clang/test/Preprocessor/init-ppc.c =================================================================== --- clang/test/Preprocessor/init-ppc.c +++ clang/test/Preprocessor/init-ppc.c @@ -391,6 +391,7 @@ // PPC-AIX-NOT:#define __64BIT__ 1 // PPC-AIX:#define _AIX 1 // PPC-AIX:#define _ARCH_PPC 1 +// PPC-AIX:#define _ARCH_PPC64 1 // PPC-AIX:#define _BIG_ENDIAN 1 // PPC-AIX:#define _IBMR2 1 // PPC-AIX:#define _LONG_LONG 1 Index: clang/lib/Basic/Targets/PPC.cpp =================================================================== --- clang/lib/Basic/Targets/PPC.cpp +++ clang/lib/Basic/Targets/PPC.cpp @@ -256,6 +256,10 @@ Builder.defineMacro("__powerpc64__"); Builder.defineMacro("__ppc64__"); Builder.defineMacro("__PPC64__"); + // Also define _ARCH_PPC64 for 32-bit on AIX. + } else { + if (getTriple().isOSAIX()) + Builder.defineMacro("_ARCH_PPC64"); } // Target properties.
Index: clang/test/Preprocessor/init-ppc.c =================================================================== --- clang/test/Preprocessor/init-ppc.c +++ clang/test/Preprocessor/init-ppc.c @@ -391,6 +391,7 @@ // PPC-AIX-NOT:#define __64BIT__ 1 // PPC-AIX:#define _AIX 1 // PPC-AIX:#define _ARCH_PPC 1 +// PPC-AIX:#define _ARCH_PPC64 1 // PPC-AIX:#define _BIG_ENDIAN 1 // PPC-AIX:#define _IBMR2 1 // PPC-AIX:#define _LONG_LONG 1 Index: clang/lib/Basic/Targets/PPC.cpp =================================================================== --- clang/lib/Basic/Targets/PPC.cpp +++ clang/lib/Basic/Targets/PPC.cpp @@ -256,6 +256,10 @@ Builder.defineMacro("__powerpc64__"); Builder.defineMacro("__ppc64__"); Builder.defineMacro("__PPC64__"); + // Also define _ARCH_PPC64 for 32-bit on AIX. + } else { + if (getTriple().isOSAIX()) + Builder.defineMacro("_ARCH_PPC64"); } // Target properties.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits