aaron.ballman added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:439 + [&](const FieldDecl *F) { + if (!HasRecordClasMemberSet.count(F)) + { ---------------- MTC wrote: > I believe `DenseSet::contains` is more appropriate here. +1 to the suggestion to use `contains()`. ================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h:79 + // initialization. + llvm::DenseSet<const FieldDecl *> HasRecordClasMemberSet; }; ---------------- CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107641/new/ https://reviews.llvm.org/D107641 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits