gandhi21299 added inline comments.
================ Comment at: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu:10 + +// GFX90A-CAS: A compare and swap loop was generated for an atomic operation at system memory scope +// GFX90A-CAS-LABEL: _Z14atomic_add_casPf ---------------- rampitec wrote: > Need tests for all scopes. `__atomic_fetch_add` does not take scope as an argument, how could I add tests with different scopes? ================ Comment at: clang/test/CodeGenOpenCL/atomics-remarks-gfx90a.cl:25 + +// GFX90A-CAS-LABEL: @atomic_cas_system +// GFX90A-CAS: atomicrmw fadd float addrspace(1)* {{.*}} syncscope("workgroup-one-as") monotonic ---------------- For some reason, remarks are not emitted here. The command to run looks right above... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits