rsmith added inline comments.
================ Comment at: clang/test/CXX/drs/dr2xx.cpp:600 -namespace dr248 { // dr248: yes c++11 - // FIXME: Should this also apply to c++98 mode? This was a DR against C++98. ---------------- aaron.ballman wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > This means we're going to drop our support of this DR on > > > https://clang.llvm.org/cxx_dr_status.html when that page gets > > > regenerated. What should our status of that DR be with these changes? > > Good question! > > I will change it to `Superseded by P1949`. What do you think? > Because we're treating this as a DR, hopefully there's a DR number we could > use instead of the paper number. @rsmith -- how should we handle this? I don't think there is nor will ever be a DR number for this; using the P number here seems like the best option available to us. Ultimately the "sup" marking here serves two purposes: - tracking what is done, when it was done, and what's still left to do - providing a way to determine why we're not doing what a DR resolution says to do I think it would be fine to write this as `dr248: sup P1949R7`, and in the `make_cxx_status` script, generate text that says "Superseded by P1949R7" like in your edits to `cxx_dr_status.html` and color DRs superseded by papers as `class="na"` (because the DR no longer applies due to the paper). (Not saying that's the only option, but I think it would be a reasonable choice.) Separately, please don't remove the tests here; instead update them to show what the new behavior is, and add tests if necessary so that it's clear in what way the DR's behavior has been superseded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits