sidneym added inline comments.
================
Comment at:
compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124
+
+bool internal_iserror(uptr retval, int *rverrno) {
+ if (retval == (uptr)-1) {
----------------
bcain wrote:
> @sidneym Can you confirm that this implementation looks correct? I thought
> the convention was -1 for failed syscalls.
Maybe it should be <0 instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108083/new/
https://reviews.llvm.org/D108083
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
