glider added inline comments.

================
Comment at: llvm/include/llvm/IR/Attributes.td:90
+/// Do not instrument function with sanitizers.
+def DisableSanitizerInstrumentation: 
EnumAttr<"disable_sanitizer_instrumentation", [FnAttr]>;
+
----------------
melver wrote:
> There's this long-tail of changes required for adding new keywords to the IR. 
> Have a look at https://reviews.llvm.org/D102772 -- things that I see 
> currently missing are various tests etc.
It's ridiculous that we have so many handwritten files that list all the 
attributes (all those llvm.vim etc)
But I'll definitely need to update BitcodeReader and the tests. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108029/new/

https://reviews.llvm.org/D108029

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to