sunlin added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:307
+  if (StringRef(D.Dir).startswith(SysRoot)) {
     addPathIfExists(D, D.Dir + "/../lib", Paths);
+    addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths);
----------------
MaskRay wrote:
> Is `D.Dir + "/../lib"` still needed?
Yes, it's still usefull. When running the clang from compiled folder (eg: 
`.../build.debug/bin/clang`), it will try to access the 
`.../build.debug/bin/../lib`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108286/new/

https://reviews.llvm.org/D108286

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to