kstoimenov marked an inline comment as done.
kstoimenov added inline comments.
================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1640
+def int_asan_check_memaccess :
+ Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty],
----------------
vitalybuka wrote:
> vitalybuka wrote:
> > PTAL at lvm.read_register.i32
> >
> > How about:
> >
> > llvm.asan.check.memaccess ->
> > lvm.asan.check_read
> > lvm.asan.check_write
> > lvm.asan.kernel.check_read
> > lvm.asan.kernel.check_write
> >
> > Even better
> > lvm.asan.check_read.{i8, i16, i32, ...}
> > lvm.asan.check_write.{i8, i16, i32, ...}
> > lvm.asan.kernel.check_read.{i8, i16, i32, ...}
> > lvm.asan.kernel.check_write.{i8, i16, i32, ...}
> >
> Looks like underscore is not used in intrinsic names, so essentially the same
> with dots.
Sounds good to me. I do the full expansion so there will be 20 intrinsics
altogether. I will update the code and ping you when done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107850/new/
https://reviews.llvm.org/D107850
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
